Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP inflight request is aborted ignoring preWait #116

Closed
mivanilov opened this issue Feb 7, 2024 · 2 comments
Closed

HTTP inflight request is aborted ignoring preWait #116

mivanilov opened this issue Feb 7, 2024 · 2 comments

Comments

@mivanilov
Copy link

mivanilov commented Feb 7, 2024

Issue: http inflight request is aborted on app getting e.g. SIGTERM even though SuspendApp preWait is configured to be e.g. 10s.

Expectation: http inflight requests are allowed to complete within preWait on app getting e.g. SIGTERM.

Steps to reproduce: (example app code issue-suspendapp-inflight-abort.zip)

  • Start app with -Dio.ktor.server.engine.ShutdownHook=false
  • curl http://localhost/ping -v
  • kill -s SIGTERM `lsof -t -i:80`
  • Inflight request is aborted immediately ignoring preWait

Looks like an issue is with Ktor itself as I also get the same outcome using just Ktor embeddedServer (also raised an issue with Ktor)
Nevertheless I thought maybe Arrow community could also help investigating this issue.

@nomisRev
Copy link
Member

nomisRev commented Feb 7, 2024

@mivanilov thank you for creating this ticket! It'll allow me to keep an eye on things.

@mivanilov
Copy link
Author

@nomisRev no actual issue here, my bad, sorry for this... I've explained it here https://youtrack.jetbrains.com/issue/KTOR-6755/HTTP-inflight-request-is-aborted-ignoring-shutdownGracePeriod#focus=Comments-27-9188264.0-0
Closing this ticket too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants