Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cython support to speed up arrow.get #617

Open
jadchaar opened this issue Jul 17, 2019 · 3 comments
Open

Add Cython support to speed up arrow.get #617

jadchaar opened this issue Jul 17, 2019 · 3 comments

Comments

@jadchaar
Copy link
Member

We had a PR in 2017 that addressed this issue (#414), but it was never merged in, and the Cython implementation has since gotten outdated. It would be great if someone could take on this issue.

@mashfy13
Copy link

I'm interested in helping out with the Cython implementation. I will definitely take a look at it!

@mashfy13
Copy link

Is there any way to optimize the *args and **kwargs lists using Cython? I've been considering how to approach this but it seems like it would be pretty difficult since these lists can have different types based on what is getting passed to the function. I am currently thinking that these two lists would have to remain in their Python implementation.

@jadchaar
Copy link
Member Author

Hi @mashfy13, I am not too familiar with Cython myself, but we created this issue since the old PR became stale after a lack of review: #414. You can refer to the PR for a bit of inspiration. It may be best to focus the Cython optimizations on the parsing elements of Arrow since this may be used most often and in bulk.

I wish I could be of more help, but I have not gotten around to learning the ins and outs of Cython yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants