Skip to content

Commit

Permalink
use just the hash as a selector in ie7 Fixes jquery-archive#4917
Browse files Browse the repository at this point in the history
  • Loading branch information
johnbender authored and arschmitz committed Oct 16, 2012
1 parent 55f027b commit f7e2351
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions js/widgets/popup.js
Expand Up @@ -552,7 +552,7 @@ define( [ "jquery",


if ( this.options.overlayTheme && androidBlacklist ) { if ( this.options.overlayTheme && androidBlacklist ) {
/* TODO: /* TODO:
The native browser on Android 4.0.X ("Ice Cream Sandwich") suffers from an issue where the popup overlay appears to be z-indexed The native browser on Android 4.0.X ("Ice Cream Sandwich") suffers from an issue where the popup overlay appears to be z-indexed
above the popup itself when certain other styles exist on the same page -- namely, any element set to `position: fixed` and certain above the popup itself when certain other styles exist on the same page -- namely, any element set to `position: fixed` and certain
types of input. These issues are reminiscent of previously uncovered bugs in older versions of Android’s native browser: types of input. These issues are reminiscent of previously uncovered bugs in older versions of Android’s native browser:
https://github.com/scottjehl/Device-Bugs/issues/3 https://github.com/scottjehl/Device-Bugs/issues/3
Expand Down Expand Up @@ -746,7 +746,9 @@ define( [ "jquery",
$.mobile.popup.handleLink = function( $link ) { $.mobile.popup.handleLink = function( $link ) {
var closestPage = $link.closest( ":jqmData(role='page')" ), var closestPage = $link.closest( ":jqmData(role='page')" ),
scope = ( ( closestPage.length === 0 ) ? $( "body" ) : closestPage ), scope = ( ( closestPage.length === 0 ) ? $( "body" ) : closestPage ),
popup = $( $link.attr( "href" ), scope[0] ), // NOTE make sure to get only the hash, ie7 (wp7) return the absolute href
// in this case ruining the element selection
popup = $( $.mobile.path.parseUrl($link.attr( "href" )).hash, scope[0] ),
offset; offset;


if ( popup.data( "popup" ) ) { if ( popup.data( "popup" ) ) {
Expand Down

0 comments on commit f7e2351

Please sign in to comment.