Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it expected to work on MacOS? #6

Closed
siara-cc opened this issue Nov 8, 2022 · 6 comments
Closed

Is it expected to work on MacOS? #6

siara-cc opened this issue Nov 8, 2022 · 6 comments

Comments

@siara-cc
Copy link

siara-cc commented Nov 8, 2022

Hi, I could not get it to work on MacOS. When I click on the DarkPDF icon, only the instructions appear and even Ctrl-Shift-9 or Cmd-Shift-9 does not seem to work on PDF documents opened within Chrome.

@ArshSB
Copy link
Owner

ArshSB commented Nov 8, 2022

Hi there,

Thanks for opening the issue. I checked with a friend's MacBook running macOS Monterey and the extension was working fine for him (worked on both local and online PDF files along with the keyboard shortcut).

I'm not sure what might be the problem in your case. Can you tell me what macOS version you are using?

@siara-cc
Copy link
Author

siara-cc commented Nov 9, 2022

Hi, thanks for the quick reply. It worked after I enabled file URLs. So it was just my misunderstanding.

However, I could not get it to darken the PDF itself, like the software Negative I use. Please see the attached video. Is it possible to do the same with DarkPDF?

DarkPDFDemo.mp4

In any case, thanks for making this extension. Great work!!

@siara-cc siara-cc closed this as completed Nov 9, 2022
@ArshSB
Copy link
Owner

ArshSB commented Nov 10, 2022

I've noticed a similar problem when using DarkPDF with other extensions/programs that interact with the PDF such as DarkReader. The solution, of course, is to use only one of them at a time.

Perhaps something else is also trying to do same thing as DarkPDF in Chrome? Does it do the same thing for online PDF files?

@siara-cc
Copy link
Author

I don't have other similar extensions installed, but I found that the Auto Dark Mode setting I am using in chrome://flags is causing trouble:

image

I am using this setting to see all web pages in dark mode as I was uncomfortable to install an extension for this purpose.

When this setting is disabled, DarkPDF works as intended. Is there a way of making DarkPDF invert PDFs even if this is enabled?

@ArshSB
Copy link
Owner

ArshSB commented Nov 10, 2022

Very interesting, I didn't know Chrome had that built-in feature!

Unfortunately, as far as I know, I don't have a way to fix this. DarkPDF injects some simple CSS on to the page to enable dark mode, and I believe other programs do something similar to achieve the same purpose, so when they both inject some CSS, they might interfere with each other. A possible solution would be identifying and fixing that interference in the HTML code, but that's beyond the scope of this extension 😞

I did a quick test and it seems DarkReader extension works well in your case (has dark mode for PDFs while the auto dark mode for web content setting is enabled).

I appreciate your feedback on this, take care!

@siara-cc
Copy link
Author

Thanks for the info on DarkReader!! It works for both websites and PDFs as you said, even without the "Auto dark mode" setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants