Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package has too many dependencies #1

Open
karthik opened this issue Mar 22, 2019 · 2 comments
Open

Package has too many dependencies #1

karthik opened this issue Mar 22, 2019 · 2 comments

Comments

@karthik
Copy link

karthik commented Mar 22, 2019

I am the editor on your JOSS submission. Your package has too many packages listed under Depends. This is bad practice and you should only use Imports where possible (and import specific functions you need). All the other optional bits need to be moved to Suggests.

Right now I cannot install your package, nor can the reviewer I assigned. It's because rpanel cannot be installed without specific tcltk widgets. This is not supported on Osx and therefore cannot be a hard dependency. This may work on Windows (which I'm assuming you're on). What is the purpose of rpanel here? What functions are you importing?

refactoring your package will make it possible for others to install it, particularly from GitHub since we are not reviewing what is on CRAN.

@karthik
Copy link
Author

karthik commented Jun 25, 2019

Still waiting on a response to this issue, @arsilva87
cc/ openjournals/joss-reviews#1321

@arsilva87
Copy link
Owner

@karthik The package does not have those dependencies anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants