Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reafactor ui-modal #431

Open
BataevDaniil opened this issue Sep 16, 2022 · 4 comments
Open

Reafactor ui-modal #431

BataevDaniil opened this issue Sep 16, 2022 · 4 comments
Labels
good first issue Good for newcomers

Comments

@BataevDaniil
Copy link
Contributor

  1. move hide, show, isVisible in other atom
  2. add +-decorator for animating modal
  3. add queue for controlle many modal
  4. add example with controlle modal and data for modal
@artalar
Copy link
Owner

artalar commented Sep 16, 2022

The main issue is internal realisation and it reliability. It should be written in FSM style. Btw, I already thinking around a helper for FSM describing.

@artalar
Copy link
Owner

artalar commented Mar 18, 2023

@BANOnotIT
Copy link
Collaborator

Do you really want to have atom controlling component to be outside of the component? That breaks encapsulation I would say

@artalar
Copy link
Owner

artalar commented Mar 18, 2023

If this logic is more than 50 LoC - defenetly yes! react-aria and ariakit show us the this pattern is good and powerful, it give us more flexibility.

@BANOnotIT BANOnotIT added good first issue Good for newcomers and removed docs labels Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants