Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KDTree namespace conflict #110

Closed
proc-sim opened this issue Nov 25, 2022 · 4 comments · Fixed by #117
Closed

KDTree namespace conflict #110

proc-sim opened this issue Nov 25, 2022 · 4 comments · Fixed by #117

Comments

@proc-sim
Copy link

proc-sim commented Nov 25, 2022

I have a large project I'm testing CDT in, and there happens to be a class in the project named KDTree which causes CDT to generate all kinds of unrelated errors during compilation due to the naming conflict between the KDTree class and CDT's KDTree namespace.

Nesting the KDTree namespace of the CDT library inside the CDT namespace solves the problem. It probably makes sense to have all CDT classes/namespaces nested inside the CDT namespace....KDTree is the only one I see outside of it.

@artem-ogre
Copy link
Owner

Thank you for opening the issue @Tysoni!

Yes, definitely, this is reasonable to do. It sounds like you already made it to work. Would you mind making a PR?

@proc-sim
Copy link
Author

Unfortunately I'm pretty limited in my knowledge/usage of github at the moment, so I'm only able to report :)

artem-ogre added a commit that referenced this issue Jan 3, 2023
@artem-ogre artem-ogre linked a pull request Jan 3, 2023 that will close this issue
artem-ogre added a commit that referenced this issue Jan 3, 2023
@artem-ogre
Copy link
Owner

@Tysoni I merged the fix. Please let me know if it worked for you.

@proc-sim
Copy link
Author

proc-sim commented Jan 4, 2023

Perfect, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants