Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if ProGuard rules required for RxJava v2 #44

Closed
artem-zinnatullin opened this issue Oct 8, 2016 · 6 comments
Closed

Check if ProGuard rules required for RxJava v2 #44

artem-zinnatullin opened this issue Oct 8, 2016 · 6 comments
Assignees

Comments

@artem-zinnatullin
Copy link
Owner

RxJava v2 release is coming, this issue will collect info regarding ProGuard for RxJava v2.

// cc @vanniktech created this as continuation of our discussion.

@artem-zinnatullin
Copy link
Owner Author

Forgot to mention: if ProGuard rules won't be required for RxJava v2 — this project will be iceboxed since RxJava v2 has same requirements to runtime as RxJava v1 and is basically long-term replacement for v1.

If we'll see new releases of RxJava v1 after v2 release — I'll keep this project updated until I stop using v1 at work, then I'll switch to community (PRs) driven releases.

@vanniktech
Copy link
Contributor

I'm already using Rx2 partially in production (RxJava 2, Retrofit, RxAndroid) and so far I didn't need to specify anything.

@artem-zinnatullin
Copy link
Owner Author

Yup, looks like RxJava v2 does not use sun.misc.Unsafe nor Java Reflection API (except in arrays creation in Subjects) -> it does not need ProGuard rules at the moment, which is great!

@artem-zinnatullin
Copy link
Owner Author

@akarnokd any plans to use Unsafe or Reflection APIs (class/field/method lookup by name) in RxJava v2?

@akarnokd
Copy link

akarnokd commented Oct 8, 2016

We won't use Unsafe and the only reflection is to detect setRemoveOnCancelPolicy in scheduler setup

@artem-zinnatullin
Copy link
Owner Author

So, ProGuard rules for RxJava v2 are not required at the moment. I'm closing this issue and updating README.md to mention that, thanks @vanniktech and @akarnokd!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants