Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show once loading when starting the webapp #13

Closed
arshubham opened this issue Aug 11, 2017 · 14 comments
Closed

Only show once loading when starting the webapp #13

arshubham opened this issue Aug 11, 2017 · 14 comments

Comments

@arshubham
Copy link

On certain websites like GitHub the events such as selecting a repo or searching shows loading icon for a few seconds till the page is loaded. Similarly it also happens on google when switching from search tab to news tab.
It is very disconnecting to see the loading bar popup again and again. It would be better if it is only shown when the initial web page is loading.

@artemanufrij
Copy link
Owner

@arshubham could you test current master branch, please?

@arshubham
Copy link
Author

Looks great. But now it has an issue that if the internet is slow we don't have a feedback that the page is loading. What you can do is add a spinner in the title bar such as in Appcenter.

@arshubham
Copy link
Author

You can use the current icon of the application with on the left side of the App Title and change it into the spinner when the page is loading. (see Firefox)

@arshubham arshubham reopened this Aug 11, 2017
@artemanufrij
Copy link
Owner

@arshubham please test curren master branch. I've added a spinner into header bar

@arshubham
Copy link
Author

It's great. During the initial load it shows two spinners, one in the header and one on the page. I recommend replacing the spinner on the page with App icon giving it a splash screen effect.

@artemanufrij
Copy link
Owner

@arshubham can be tested

@artemanufrij artemanufrij self-assigned this Aug 11, 2017
@arshubham
Copy link
Author

arshubham commented Aug 11, 2017

Works as expected. But can we have a 64x64 icon if provided by the icon theme and only fallback if unavailable. The current icon looks a little small.
Secondly, is it possible to have transitions with GTK+ between the splash and the main webpage.

@artemanufrij
Copy link
Owner

max. size of an icon is 48x48:
https://valadoc.org/gtk+-3.0/Gtk.IconSize.html

do you mean like slide down?

@arshubham
Copy link
Author

Yes, Some tansition like slide down or zoom out.

Some icon themes like Papirus provides with 64x64 icons.
screenshot from 2017-08-11 23-46-17

@artemanufrij
Copy link
Owner

@arshubham "splash screen" slide up can be tested....

@arshubham
Copy link
Author

Looks nice, but you slow it down a little. It's too fast.

@artemanufrij
Copy link
Owner

@arshubham done

@arshubham
Copy link
Author

It's perfect.

@artemanufrij
Copy link
Owner

@arshubham Thank you for your support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants