Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to copy link of the current page. #16

Closed
arshubham opened this issue Aug 11, 2017 · 7 comments
Closed

Add ability to copy link of the current page. #16

arshubham opened this issue Aug 11, 2017 · 7 comments
Assignees

Comments

@arshubham
Copy link

A link icon on the header bar which copies the link of the current page with a click (with toast for successful copy) would be great.

@artemanufrij
Copy link
Owner

hey @arshubham could you test current master branch please?

bildschirmfoto von 2017-10-15 19 25 47

@arshubham
Copy link
Author

Works great. However I have a few suggestions.

  1. The icon looks more like for copying a file rather than a link . Maybe something like attachment icon (see GitHub editor) or Copy link icon used in Firefox 57+ page action menu.
  2. A link copy feedback similar to used in firefox 57+

@artemanufrij
Copy link
Owner

@arshubham look into /usr/share/icons/elementary/actions/symbolic/ which icon do you mean?

@arshubham
Copy link
Author

arshubham commented Oct 15, 2017

insert-link-symbolic.svg
It's the closest to what is used in firefox just a mirror image.

@artemanufrij
Copy link
Owner

done

@artemanufrij
Copy link
Owner

I would implement feedback like "external link" but auto close is currently broken. So I have to wait for fixing it. Than I will implement it.

@artemanufrij artemanufrij self-assigned this Oct 15, 2017
@artemanufrij
Copy link
Owner

Was shipped with last version. (is currently waiting for human testing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants