Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long Track Pieces do not Show when First Coordinate is not in View #17

Open
Daniel-Gill opened this issue Feb 16, 2021 · 2 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@Daniel-Gill
Copy link
Collaborator

An unintentional side-effect of pull #14.

The code for drawing the lines uses the first coordinate in the list to determine if the line is in view. This should be changed that all coordinates in the line are checked against the map bounds.

Example:
image

Moved slightly further North, and the line appears:
image

@Daniel-Gill Daniel-Gill added the bug Something isn't working label Feb 16, 2021
@Daniel-Gill Daniel-Gill self-assigned this Feb 16, 2021
@Daniel-Gill
Copy link
Collaborator Author

I've added a few lines to solve the problem initially in pull #18.

I'm not closing this issue yet, as this is very inefficient.

@Daniel-Gill
Copy link
Collaborator Author

Maybe a better option to find whether a line is in view is to imagine a straight line between the first and last points, and check whether that line intersects the view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant