Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mouse image panning #136

Closed
diniamo opened this issue Jun 9, 2024 · 10 comments
Closed

Add mouse image panning #136

diniamo opened this issue Jun 9, 2024 · 10 comments
Assignees
Labels

Comments

@diniamo
Copy link
Contributor

diniamo commented Jun 9, 2024

Hopefully I didn't miss anything, but I couldn't find anything in the documentation mentioning this, nor any closed issues.

I'm switch to swayimg either way since there are too many issues with imv, but dragging the image with my mouse is something I do naturally so not being able to do that feels really bad.

@artemsen
Copy link
Owner

artemsen commented Jun 9, 2024

Which version of swayimg do you use?
Dragging image with mouse was added in version 2.1.
Simply enlarge the image to a size larger than the window, press left button and drag.
But for now there is still a performance bug.

@diniamo
Copy link
Contributor Author

diniamo commented Jun 9, 2024

Why is panning restricted to the bounds of the window? That doesn't make sense to me.

@artemsen
Copy link
Owner

artemsen commented Jun 9, 2024

Perhaps I misunderstood your question.
If the image is smaller than the window, it is always centered and cannot be moved outside the window using the mouse or keyboard.

@diniamo
Copy link
Contributor Author

diniamo commented Jun 9, 2024

I am asking why that restriction exists, why can't I move the image however I want to?

@artemsen
Copy link
Owner

artemsen commented Jun 9, 2024

It is not a restriction, it is by design.
Just curious, why would you want to open an image and move it outside the window?
Want to see the window background? =)

@diniamo
Copy link
Contributor Author

diniamo commented Jun 9, 2024

Generally because, I'd rather move the relevant part of the image to the center of my screen, instead of turning my neck to the side.

@artemsen
Copy link
Owner

artemsen commented Jun 9, 2024

Oh, I get it, this is a problem with large displays.
I will make this logic optional.

@artemsen artemsen self-assigned this Jun 9, 2024
@diniamo
Copy link
Contributor Author

diniamo commented Jun 11, 2024

Awesome, thanks.

Though yeah, the performance problems make this useless.

One question: why is it possible to have frames rendered where the gui (everything except the image, like the background, text) doesn't fill the window?

@artemsen
Copy link
Owner

Though yeah, the performance problems make this useless.

Try to build release version (it is by default in the latest master) and disable antialiasing (if you use it).

why is it possible to have frames rendered where the gui (everything except the image, like the background, text) doesn't fill the window?

I don't get the question, sorry =)
Do you mean window decoration (title/buttons) or what?

@diniamo
Copy link
Contributor Author

diniamo commented Jun 11, 2024

Welp, using latest fixes the issue I was trying to explain as well. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants