Add support for non-integer primary key user models #216
Conversation
codingjoe
force-pushed
the
urls
branch
2 times, most recently
from
3748214
to
edccbf6
Compare
codingjoe
force-pushed
the
urls
branch
4 times, most recently
from
8ec217d
to
f44d052
Compare
|
Overall, I like the changes, but it will take me a while to test them. I'll check it out next week. |
|
@codingjoe could you please resolve the conflicts? |
Codecov Report
@@ Coverage Diff @@
## master #216 +/- ##
==========================================
- Coverage 95.63% 88.51% -7.12%
==========================================
Files 7 7
Lines 206 209 +3
==========================================
- Hits 197 185 -12
- Misses 9 24 +15
Continue to review full report at Codecov.
|
@Mogost done :) |
codingjoe
force-pushed
the
urls
branch
4 times, most recently
from
d966b83
to
bccbab9
Compare
There was a problem hiding this comment.
I tested it. All in all, it seems to be working fine. The backward compatibility is there.
There are a couple of things which I have put in my suggestions.
Another thing, when it will be released, it is desirable to reflect the changes in the release notes well.
codingjoe
force-pushed
the
urls
branch
2 times, most recently
from
24f84ee
to
7e0ba3d
Compare
|
@Mogost regarding the release notes. I would prefer to write those only in GitHub in the future. I would actually prefer to remove the current change log file to avoid confusion. It is included in old distributions, that should be enough. I will open a separate PR for that. |
Simplify URL and view structure. Add support for multiple PK types based on URL pattern as well as natural key support via URL patterns. Changes: * Deprecate `HIJACK_URL_ALLOWED_ATTRIBUTES` setting favoring `HIJACK_USER_URL_PATTERN`. * Deprecate URL names `login_with_id`, `login_with_username` and `login_with_email` favoring `acquire`. * Deprecate URL name `release_hijack` favoring `release`. * Deprecate views `login_with_id`, `login_with_username` and `login_with_email` favoring `release_user_view`. * Deprecate view `release_hijack` favoring `release_user_view`. Close #196 Close #183 Close #184 Close #198 Close #175 Co-Authored-By: Alexandr Artemyev <mogost@gmail.com>
|
Probably after this merge it is worth making a release |
|
this one https://pypi.org/project/django-hijack/2.3.0 😉 |
|
Actually, once we updated the template integration, I would shoot for v3 (major) and remove all departed code. |
|
@codingjoe We should not remove old code until we have dealt with django-hijack-admin |
Simplify URL and view structure. Add support for multiple PK types
based on URL pattern as well as natural key support via URL patterns.
Changes:
HIJACK_URL_ALLOWED_ATTRIBUTESsetting favoringHIJACK_USER_URL_PATTERN.login_with_id,login_with_usernameandlogin_with_emailfavoringacquire.release_hijackfavoringrelease.login_with_id,login_with_usernameandlogin_with_emailfavoringrelease_user_view.release_hijackfavoringrelease_user_view.Close #196
Close #183
Close #184
Close #198
Close #147
Close #175