Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working in Laravel 5.5 #100

Closed
MonrealRyan opened this issue Oct 12, 2017 · 12 comments
Closed

Not working in Laravel 5.5 #100

MonrealRyan opened this issue Oct 12, 2017 · 12 comments

Comments

@MonrealRyan
Copy link

i try to run the vendor publish but don't see the plugin

@carusogabriel
Copy link
Contributor

carusogabriel commented Oct 12, 2017

I’ve already submitted a PR (#97), was merged, but not release yet 🙁

@MonrealRyan
Copy link
Author

MonrealRyan commented Oct 16, 2017

@Gabriel-Caruso - any reason why it does not release?

@almamund
Copy link

If you're using laravel's package auto discovery, config wont be published. Add service provider in app.php.

@carusogabriel
Copy link
Contributor

@vinicius73 Could you publish the new version with Package Discovery support? 😄

@MonrealRyan
Copy link
Author

@dinajpuri I tried it but it does not work.

Note: If you are using Laravel 5.5, the steps 2 and 3, for providers and aliases, are unnecessaries. SEOTools supports Laravel new Package Discovery.

@almamund
Copy link

Strange! I just published it again (screenshot). My laravel version is 5.5.14
seotools

Btw, I know that adding providers and aliases are not necessary. But without adding service provider the config file was not being published.

@jnbn
Copy link
Contributor

jnbn commented Oct 22, 2017

can you please release 0.11.0 @vinicius73 ?

@isneezy
Copy link

isneezy commented Oct 23, 2017

+1

@vinicius73
Copy link
Member

v0.11.1 published https://github.com/artesaos/seotools/releases/tag/v0.11.1

please send feedbacks

@jnbn
Copy link
Contributor

jnbn commented Oct 26, 2017

Thanks ;)

@carusogabriel
Copy link
Contributor

@vinicius73 Is working perfectly in Laravel 5.5, thanks 👏

@MonrealRyan Update your artesao/seotools to version 0.11.1 and you're ready to go with Laravel 5.5. You can close this issue.

@MonrealRyan
Copy link
Author

@Gabriel-Caruso - got it, sorry for late response. :) and thank you very much for the work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants