Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fb:app_id support #83

Closed
taliptako opened this issue Nov 10, 2016 · 10 comments
Closed

fb:app_id support #83

taliptako opened this issue Nov 10, 2016 · 10 comments

Comments

@taliptako
Copy link

I want to add my facebook app_id and its should look like this

with seotools i can only add it like this

@vinicius73
Copy link
Member

try SEOMeta::addMeta(...);

@paulocastellano
Copy link

+1

@ozgurkaragoz
Copy link

@vinicius73

SEOMeta::addMeta('app_id', 'xxx') returns <meta name="fb:app_id" content="xxx"> but Facebook Sharing Debugger dont accept this code.

It should be: <meta property="fb:app_id" content="xxx" />

@ozgurkaragoz
Copy link

Ok I understand. addMeta method has third parameter. Thanks @vinicius73

SEOMeta::addMeta('fb:app_id', 'xxx', 'property');

@ahosker
Copy link

ahosker commented Jan 16, 2022

It would be nice to have it by default in the seotools config? Don't want to add this on every page.

@J-Brk
Copy link
Collaborator

J-Brk commented Jan 16, 2022

It would be nice to have it by default in the seotools config? Don't want to add this on every page.

Then you should call it from your base controller or middleware.

@kossa
Copy link

kossa commented Feb 4, 2022

@J-Brk On each controller/method???!! really!!

@ahosker
Copy link

ahosker commented Feb 4, 2022

Then you should call it from your base controller or middleware.

That would solve it @J-Brk . Will give me an opportunity to understand Middleware too, not had a "need" for it until now.

On each controller/method???!! really!!

@kossa all controllers extend the base controller. So if we follow @J-Brk suggestion, would only have to declare it once on the base controller and all that extend it will implement it. The alternative is middleware, which is more elegant I believe.

It would be nice to have it by default in the seotools config?

I still believe this is the way forward though. If we have Google/Bing Webmaster Tools, etc.. set in the config already. Its not a leap to suggest FB should be on.

@kossa
Copy link

kossa commented Feb 4, 2022

When it's easy to add it in config why use Controller/Middleware? I know everything can be on middleware or base controller, but let's keep them for interesting things ;)

@J-Brk
Copy link
Collaborator

J-Brk commented Feb 4, 2022

Personally I think it's not practical to maintain an active list of custom tags; while with a single line of code you can already easily add the custom tags you want. A good example of a short lived tag; is the one you mentioned. The fb:app_id is deprecated nowadays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants