Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitter image #99

Closed
kskrlin opened this issue Oct 11, 2017 · 5 comments
Closed

Twitter image #99

kskrlin opened this issue Oct 11, 2017 · 5 comments

Comments

@kskrlin
Copy link

kskrlin commented Oct 11, 2017

Twitter::addImage('example.jpeg');

produces this code:

Why is the 0 after images? And by the Twitter, this meta tag must be twitter:image

@vinicius73
Copy link
Member

more info please.

@timogwl
Copy link

timogwl commented Feb 12, 2018

I guess I'm having the same issue. When you use: Twitter::addImage('image.jpg');

this is what you get: <meta name="twitter:images0" content="image.jpg" />

But SEO::twitter()->setImage('image.jpg'); is working fine.

@sbtsrbayer
Copy link
Contributor

Issue #78 and pull request #79 both reference this issue. Image0 was a part of an old way that twitter used to do their meta tags.

In this package, Twiitter:addImage is now deprecated in favor of Twitter:setImage (as @timogauweiler discovered, and the Issue #78 ) according to the above pull request and Issue. The resolution to this would be update the documentation for Twitter on this repo.

@seinoxygen
Copy link

seinoxygen commented Apr 24, 2019

Using SEO::addImages($url); still adds the image index after twitter:images

This line in TwitterCards.php is causing the issue:
$key = $prefix.$key; elseif (is_string($prefix)):

@jonathan-hooper-osf
Copy link
Contributor

I think I have a fix for this issue here: #191. SEOTools.php was still using the deprecated Twitter:addImage function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants