Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Calling setStyle does not update storage, unlike setComponents #1049

Closed
dsgh opened this issue Apr 16, 2018 · 1 comment · Fixed by #1050
Closed

[Bug] Calling setStyle does not update storage, unlike setComponents #1049

dsgh opened this issue Apr 16, 2018 · 1 comment · Fixed by #1050
Labels

Comments

@dsgh
Copy link
Contributor

dsgh commented Apr 16, 2018

I'm configuring grapesjs in a way to allow users to edit the html and css source (by calling setComponents and setStyle respectively). There is an issue regarding the storeManager where the html is stored correctly, but the css is not. Here is a fiddle showing this: https://jsfiddle.net/szLp8h4n/189/

Steps to reproduce

  1. Go into the linked fiddle
  2. Run the fiddle
  3. Open the "extended" code panels by clicking the 'Open code' icon in the top right corner (make sure the screen is wide enough that you can see it).
  4. Change the html
  5. Reload the page (or re-run the fiddle)
  6. Notice your html changes were maintained 🙂
  7. Re-open the "extended" code panels, now change the css
  8. Reload the page (or re-run the fiddle)
  9. Notice your css changes were not maintained 🙁
artf added a commit that referenced this issue Apr 18, 2018
@lock
Copy link

lock bot commented Sep 17, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the outdated label Sep 17, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Sep 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant