Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Brazilian Portuguese language support (#2652) #2653

Merged
merged 2 commits into from Apr 1, 2020

Conversation

Joaovjs
Copy link
Contributor

@Joaovjs Joaovjs commented Mar 15, 2020

Closes #2652

Copy link
Member

@artf artf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pt-BR.js is not a valid name for the i18n file, it should be compliant to ISO 639-1
so you have to change it in pt.js

Copy link
Contributor Author

@Joaovjs Joaovjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed

@enricodias
Copy link

I really think the software should differentiate the pt-PT from the pt-BR. A Brazilian usually sees pt-PT versions as poor translations and I believe the Portuguese users feel the same about pt-BR versions. Both languages also tend to use different words for IT related things.

@artf artf added this to In progress in Release v0.16.12 via automation Apr 1, 2020
@artf artf merged commit ce81833 into GrapesJS:dev Apr 1, 2020
Release v0.16.12 automation moved this from In progress to Done Apr 1, 2020
@artf
Copy link
Member

artf commented Apr 1, 2020

Thanks @Joaovjs

@Joaovjs Joaovjs deleted the pt-language branch December 7, 2020 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

PT-BR Language support
3 participants