Use data URL to embed images in documents #301
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows images to be embedded in the document using data URLs.
I spent nearly an hour, but I could not manage to write proper unit tests for this.
Also:
disabledUpload
options. There was a unit test for it and it worked, but coincidental.onUploadResponse
to be a String, can simply be an object.Also, there's an undocumented
name
attribute that's understood byAssertView
.