Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue#4236: added validity check before pasting #4243

Merged
merged 3 commits into from
Apr 14, 2022
Merged

Conversation

m-jojo-s
Copy link
Contributor

@m-jojo-s m-jojo-s commented Apr 6, 2022

Using sorter to test for validity if:

  • component can be pasted inside selection
  • component can be pasted inside parent of selection

Should fix issue #4236

Using sorter to test for validity if:
- component can be pasted inside selection
- component can be pasted inside parent of selection
Copy link
Member

@artf artf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @m-jojo-s for the PR, I left one comment regarding the changes and a request to switch to another API.

src/commands/view/PasteComponent.js Outdated Show resolved Hide resolved
- shifted to canMove() for paste validation
- fixed typo
@m-jojo-s m-jojo-s requested a review from artf April 14, 2022 05:42
Copy link
Member

@artf artf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @m-jojo-s 👍

@artf artf merged commit f846545 into GrapesJS:dev Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: paste command does not respect draggable/droppable properties
2 participants