Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[reactive_signature] Improve performance #77

Closed
deandreamatias opened this issue Oct 28, 2022 · 2 comments
Closed

[reactive_signature] Improve performance #77

deandreamatias opened this issue Oct 28, 2022 · 2 comments

Comments

@deandreamatias
Copy link

Can improve performance on reactive_signature with a simple change.

Current behaviour:
Apply didChange() with every change on signature (every pixel)

Expected behaviour:
Apply didChange() only when finish draw

Suggestions:
Use add didChange on onDrawEnd method of signature controller

References: flutter-form-builder-ecosystem/form_builder_extra_fields#39
@vasilich6107
Copy link
Contributor

Hi @deandreamatias
check reactive_signature 0.9.0

@deandreamatias
Copy link
Author

I can't test right now, but I seen the change and I think that is enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vasilich6107 @deandreamatias