Don't restart the app #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artginzburg
added
enhancement
ris58h
reviewed
Sep 1, 2022
|
|
||
| // Enable the event tap. | ||
| CGEventTapEnable(eventTap, true); | ||
| [self registerMouseCallback:pool]; |
There was a problem hiding this comment.
We do
NSAutoreleasePool* pool = [[NSAutoreleasePool alloc] init];
[NSApplication sharedApplication];
and
registerTouchCallback();
above, so could we just call startUnstableListeners instead?
There was a problem hiding this comment.
Seems possible, but I don't want to mess with the autorelease pool. Since I'm not sure how to measure its effect, I won't be aware if it doesn't work correctly.
P.S. Probably broke it already tbh, never seen a pool passed as a method parameter.
ris58h
reviewed
Sep 1, 2022
MiddleClick/Controller.m
Outdated
| @@ -291,18 +348,11 @@ int touchCallback(int device, Finger* data, int nFingers, double timestamp, | |||
| } | |||
|
|
|||
| /// Relaunch the app when devices are connected/invalidated. | |||
| static void restartApp() | |||
| - (void)restartApp | |||
There was a problem hiding this comment.
Could we rename it because we don't restart the app anymore?
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#45