Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix device added callback #54

Merged
merged 1 commit into from
Jan 3, 2023
Merged

Fix device added callback #54

merged 1 commit into from
Jan 3, 2023

Conversation

karlhorky
Copy link

@karlhorky karlhorky commented Dec 5, 2022 •
edited

Ref: #28 (comment)

Switches CFRelease to IOObjectRelease to fix callback when new devices added, which was broken in 5aca15

Reproduction:

  1. Connect Magic Mouse
  2. Start MiddleClick.app -> ✅ Middle click functionality works
  3. Turn Magic Mouse off and then turn it on again
  4. 💥 Middle click functionality broken

Before:

Screenshot 2022-12-05 at 16 30 24

After:

Screenshot 2022-12-05 at 16 27 03

@karlhorky karlhorky mentioned this pull request Dec 5, 2022
Closed
@artginzburg artginzburg merged commit 3c2cc74 into artginzburg:main Jan 3, 2023
@karlhorky
Copy link
Author

karlhorky commented Jan 3, 2023 •
edited

Thanks for the merge @artginzburg ! Will this be a part of a new release 2.6.0 (non pre-release) or 2.6.0.1?

@karlhorky karlhorky deleted the patch-1 branch January 3, 2023 13:31
@artginzburg
Copy link
Owner

Of course! Sorry for the delay. I'll try to release it really soon.

@karlhorky
Copy link
Author

No worries, thanks :)

@karlhorky
Copy link
Author

karlhorky commented Jan 4, 2023 •
edited

Great, looks like my patch is included in 2.6.1 (already available in Homebrew), thanks for the release and Homebrew bump!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@karlhorky @artginzburg