Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getPackageName not accessible on Android API #14

Closed
tanersener opened this issue Apr 3, 2021 · 2 comments
Closed

getPackageName not accessible on Android API #14

tanersener opened this issue Apr 3, 2021 · 2 comments
Assignees
Labels
android Affect Android platform enhancement New feature or request fixed-in-v4.5 Fixed in release v4.5 library Affects the library v4.4 Affects v4.4 release

Comments

@tanersener
Copy link
Collaborator

tanersener commented Apr 3, 2021

Getting the name of the ffmpeg-kit package loaded is not possible using the current API.

Packages class has a getPackageName method. And, Android API uses it internally. However that class and method is not accessible from another package. Access modifier of Packages class must be updated. By applying this change other Packages methods like getExternalLibraries will also become accessible.

@tanersener tanersener added enhancement New feature or request android Affect Android platform labels Apr 3, 2021
@tanersener tanersener self-assigned this Apr 3, 2021
@tanersener tanersener added this to To do in FFmpegKit 21.07 GA Release via automation Apr 3, 2021
@tanersener tanersener added library Affects the library v4.4 Affects v4.4 release LTS Affects LTS releases and removed LTS Affects LTS releases labels May 1, 2021
@github-actions
Copy link

github-actions bot commented Jul 1, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@tanersener tanersener moved this from To Do to In progress in FFmpegKit 21.07 GA Release Aug 15, 2021
@tanersener tanersener added the fixed-on-development Fixed on the development branch. Not released yet. label Aug 16, 2021
@tanersener
Copy link
Collaborator Author

Fixed in the development.

@tanersener tanersener moved this from In progress to Done in FFmpegKit 21.07 GA Release Aug 16, 2021
@tanersener tanersener added fixed-in-v4.5 Fixed in release v4.5 and removed fixed-on-development Fixed on the development branch. Not released yet. labels Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android Affect Android platform enhancement New feature or request fixed-in-v4.5 Fixed in release v4.5 library Affects the library v4.4 Affects v4.4 release
Projects
No open projects
Development

No branches or pull requests

1 participant