Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for harfbuzz complex shaper into libass #23

Closed
nofaceanime opened this issue Apr 17, 2021 · 4 comments
Closed

Support for harfbuzz complex shaper into libass #23

nofaceanime opened this issue Apr 17, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request fixed-in-v4.5 Fixed in release v4.5 flutter Affect flutter platform

Comments

@nofaceanime
Copy link

Is your feature request related to a problem? Please describe.
I am using flutter-ffmpeg for hardcoding subtitle file into video. Issue is i have arabic text and when i burn subtitle to video, it just shows blank rectangles. I checked with other languages too like chinese, thai, indic languages, and same issue happens everywhere.

Describe the solution you'd like
Fribidi is just a simple shaper, it can't handle complex languages. Harfbuzz support is really needed in ffmpeg-kit for libass library.
Fribidi is just good for latin text, but non latin languages looks totally scrambled or just appears blank rectangles or nothing at all. Few characters do appear but it makes no sense to watch anything at all. If possible, could you add harfbuzz support to ffmpeg-kit in the libass library ?

Describe alternatives you've considered
Currently i dont have any alternative solution for this.

Platform
its a general feature that can be added which will support all platforms, but basically i need it for android and ios currently.

@tanersener tanersener added enhancement New feature or request flutter Affect flutter platform labels Apr 18, 2021
@tanersener tanersener self-assigned this Apr 18, 2021
@tanersener
Copy link
Collaborator

ffmpeg-kit already supports harfbuzz. But the flutter plugin of ffmpeg-kit is not released yet. When it is published you will be able to use harfbuzz.

@nofaceanime
Copy link
Author

Oh thats great, hopefully flutter plugin for ffmpeg-kit is released soon. will be looking forward to it.

@tanersener tanersener added android Affect Android platform apple Affect Apple platforms scripts Affect build scripts and removed android Affect Android platform apple Affect Apple platforms scripts Affect build scripts labels May 1, 2021
@tanersener tanersener added this to Roadmap To Do in Flutter Support Roadmap via automation Aug 15, 2021
@arthenica arthenica deleted a comment from github-actions bot Aug 31, 2021
@arthenica arthenica deleted a comment from github-actions bot Aug 31, 2021
@tungnddev
Copy link

I have the same issue, with Android. I used ffmpeg-kit-full-gpl:4.4.LTS. After executing, my video gets only many squares in the sub line :)) Can you recheck it for me?

@tanersener tanersener moved this from Roadmap To Do to Done in Flutter Support Roadmap Oct 4, 2021
@tanersener tanersener added the fixed-in-v4.5 Fixed in release v4.5 label Oct 7, 2021
@tanersener
Copy link
Collaborator

This is fixed in v4.5.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed-in-v4.5 Fixed in release v4.5 flutter Affect flutter platform
Projects
No open projects
Development

No branches or pull requests

3 participants