fix(datepicker): fire onBlur callback properly #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/arthurdenner/react-semantic-ui-datepickers/pfws8blt5 |
Codecov Report
@@ Coverage Diff @@
## develop #241 +/- ##
===========================================
- Coverage 88.19% 87.25% -0.94%
===========================================
Files 14 14
Lines 432 463 +31
Branches 78 92 +14
===========================================
+ Hits 381 404 +23
- Misses 49 56 +7
- Partials 2 3 +1
Continue to review full report at Codecov.
|
arthurdenner
force-pushed
the
fix/onBlur-fire-range
branch
from
0ac11e9
to
f749022
Compare
|
🎉 This PR is included in version 2.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix. Closes #238.
What is the current behavior?
The
onBlurcallback is fired automatically and in the wrong moments, e.g. selecting the first date on a range input.What is the new behavior?
The callback is fired manually and the focus on the input is also controlled.
Checklist: