Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datepicker): allow empty string as placeholder #261

Merged
merged 2 commits into from
May 9, 2020

Conversation

arthurdenner
Copy link
Owner

What kind of change does this PR introduce?
Bug fix. Closes #260.

What is the current behavior?
placeholder prop is overridden with it's an empty string or null.

What is the new behavior?
If the placeholder prop is different from undefined, it's applied. Otherwise, we use the format prop as placeholder.

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

@arthurdenner arthurdenner added the bug Something isn't working label May 9, 2020
@vercel
Copy link

vercel bot commented May 9, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click on the icon next to each commit.

@codecov
Copy link

codecov bot commented May 9, 2020

Codecov Report

Merging #261 into develop will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #261   +/-   ##
========================================
  Coverage    87.25%   87.25%           
========================================
  Files           14       14           
  Lines          463      463           
  Branches        92       92           
========================================
  Hits           404      404           
  Misses          56       56           
  Partials         3        3           
Impacted Files Coverage Δ
src/index.tsx 90.52% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50b5895...9bb1bdc. Read the comment docs.

@arthurdenner arthurdenner merged commit e9cd679 into develop May 9, 2020
@arthurdenner arthurdenner deleted the fix/allow-empty-string-placeholder branch May 9, 2020 13:19
@arthurdenner
Copy link
Owner Author

🎉 This PR is included in version 2.5.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setting placeholder to empty string or null doesn't work
1 participant