Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(locales): add Czech locale #268

Merged
merged 1 commit into from
May 11, 2020
Merged

feat(locales): add Czech locale #268

merged 1 commit into from
May 11, 2020

Conversation

arthurdenner
Copy link
Owner

What kind of change does this PR introduce?
Feature. Replaces #206.

What is the current behavior?
No Czech locale available.

What is the new behavior?
New locale is available under key cs-CZ.

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

@arthurdenner arthurdenner added the enhancement New feature or request label May 11, 2020
@vercel
Copy link

vercel bot commented May 11, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/arthurdenner/react-semantic-ui-datepickers/d0j0m2wvl
✅ Preview: https://react-semantic-ui-datepickers-git-feat-czech-locale.arthurdenner.now.sh

@codecov
Copy link

codecov bot commented May 11, 2020

Codecov Report

Merging #268 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #268   +/-   ##
========================================
  Coverage    87.25%   87.25%           
========================================
  Files           14       14           
  Lines          463      463           
  Branches        92       92           
========================================
  Hits           404      404           
  Misses          56       56           
  Partials         3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9cd679...7050a69. Read the comment docs.

Copy link

@knuhol knuhol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Texts are correct

Note: Not sure in which context it is used (if it is supposed to be a title or not) but in general all weekdays and months in Czech language start with lower case

@arthurdenner arthurdenner merged commit 97e3839 into develop May 11, 2020
@arthurdenner arthurdenner deleted the feat/czech-locale branch May 11, 2020 15:41
@arthurdenner
Copy link
Owner Author

🎉 This PR is included in version 2.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants