fix(locales): fix fi-FL, nb-NO and zh-CN #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/arthurdenner/react-semantic-ui-datepickers/ren2k6w2a |
Codecov Report
@@ Coverage Diff @@
## develop #283 +/- ##
========================================
Coverage 87.11% 87.11%
========================================
Files 14 14
Lines 458 458
Branches 92 92
========================================
Hits 399 399
Misses 56 56
Partials 3 3 Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 2.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix.
What is the current behavior?
The filenames for the
fi-FLandnb-NOlocales are wrong and the type definition forzh-CNhas a typo in it. Therefore, all three locales are broken.What is the new behavior?
All three locales are working properly.
Checklist:
Notes:
Would be nice to have a script for validating a PR for locales, making sure that the language code is valid and that the filename matches the language code.