Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datepicker): support inline variant without input #286

Merged
merged 2 commits into from
Jun 4, 2020

Conversation

arthurdenner
Copy link
Owner

What kind of change does this PR introduce?
Feature. Closes #282.

What is the current behavior?
No current behavior.

What is the new behavior?
Through a new boolean prop, inline, the user can opt-in for a variant of the library without the input, and therefore, all the features related to it, e.g. clearable datepicker.

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

@arthurdenner arthurdenner added the enhancement New feature or request label May 28, 2020
@vercel
Copy link

vercel bot commented May 28, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/arthurdenner/react-semantic-ui-datepickers/fxoutao4j
✅ Preview: https://react-semantic-ui-datepickers-git-feat-support-inline-variant.arthurdenner.now.sh

@codecov
Copy link

codecov bot commented May 28, 2020

Codecov Report

Merging #286 into develop will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #286      +/-   ##
===========================================
+ Coverage    87.33%   87.44%   +0.10%     
===========================================
  Files           14       14              
  Lines          458      462       +4     
  Branches        92       93       +1     
===========================================
+ Hits           400      404       +4     
  Misses          56       56              
  Partials         2        2              
Impacted Files Coverage Δ
src/components/calendar/calendar.tsx 100.00% <100.00%> (ø)
src/index.tsx 90.67% <100.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 435dbb5...71cdd33. Read the comment docs.

@arthurdenner arthurdenner merged commit 8d3df60 into develop Jun 4, 2020
@arthurdenner arthurdenner deleted the feat/support-inline-variant branch June 4, 2020 18:22
@arthurdenner
Copy link
Owner Author

🎉 This PR is included in version 2.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inline version of datepicker
1 participant