Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support custom icon and clearIcon props #297

Merged
merged 6 commits into from
Jun 29, 2020

Conversation

arthurdenner
Copy link
Owner

What kind of change does this PR introduce?
Feature. Closes #296.

What is the current behavior?

  • It's not possible to pass a custom component, we can only use values from SemanticUIReact;
  • It's not possible to customize the clear icon, it always renders the close icon.

What is the new behavior?

  • It's possible to pass a custom component to the icon prop;
  • It's possible to pass a value from SemanticUIReact or a custom component to the clearIcon prop.

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

@arthurdenner arthurdenner added the enhancement New feature or request label Jun 17, 2020
@vercel
Copy link

vercel bot commented Jun 17, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/arthurdenner/react-semantic-ui-datepickers/8ybnevwze
✅ Preview: https://react-semantic-ui-datepickers-git-feat-support-custom-icons.arthurdenner.vercel.app

@codecov
Copy link

codecov bot commented Jun 17, 2020

Codecov Report

Merging #297 into develop will increase coverage by 0.39%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #297      +/-   ##
===========================================
+ Coverage    87.44%   87.84%   +0.39%     
===========================================
  Files           14       15       +1     
  Lines          462      477      +15     
  Branches        93       94       +1     
===========================================
+ Hits           404      419      +15     
  Misses          56       56              
  Partials         2        2              
Impacted Files Coverage Δ
src/index.tsx 90.67% <ø> (ø)
src/components/icon.tsx 100.00% <100.00%> (ø)
src/components/input.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33cbf6e...b4e3f07. Read the comment docs.

src/components/icon.tsx Show resolved Hide resolved
src/components/icon.tsx Show resolved Hide resolved
stories/index.stories.tsx Show resolved Hide resolved
@arthurdenner arthurdenner merged commit eb28dbf into develop Jun 29, 2020
@arthurdenner arthurdenner deleted the feat/support-custom-icons branch June 29, 2020 07:57
@arthurdenner
Copy link
Owner Author

🎉 This PR is included in version 2.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How do we pass a custom icon
2 participants