Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datepicker): fire onChange callback when typed date is invalid #336

Merged
merged 3 commits into from
Aug 17, 2020

Conversation

arthurdenner
Copy link
Owner

What kind of change does this PR introduce?
Bug fix. Closes #334.

What is the current behavior?
When the user types an invalid date, but input is updated but the onChange callback isn't fired.

What is the new behavior?
The callback is properly fired.

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

@arthurdenner arthurdenner added the bug Something isn't working label Aug 5, 2020
@vercel
Copy link

vercel bot commented Aug 5, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/arthurdenner/react-semantic-ui-datepickers/5j4wh1z58
✅ Preview: https://react-semantic-ui-datepicke-git-fix-onchange-invalid-typ-8932f7.arthurdenner.vercel.app

@codecov
Copy link

codecov bot commented Aug 5, 2020

Codecov Report

Merging #336 into develop will increase coverage by 0.91%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #336      +/-   ##
===========================================
+ Coverage    87.78%   88.70%   +0.91%     
===========================================
  Files           15       16       +1     
  Lines          475      487      +12     
  Branches        94       97       +3     
===========================================
+ Hits           417      432      +15     
+ Misses          56       53       -3     
  Partials         2        2              
Impacted Files Coverage Δ
src/__tests__/_utils.tsx 100.00% <100.00%> (ø)
src/index.tsx 92.26% <100.00%> (+1.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e297b8...481ca64. Read the comment docs.

@arthurdenner arthurdenner merged commit 6d18c56 into develop Aug 17, 2020
@arthurdenner arthurdenner deleted the fix/onChange-invalid-typed-date branch August 17, 2020 16:09
@arthurdenner
Copy link
Owner Author

🎉 This PR is included in version 2.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong value recorded. onChange() callback is not fired when the new input date is in invalid format
1 participant