Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed incorrect country ISO for Finland. #347

Merged
merged 3 commits into from
Aug 13, 2020
Merged

Fixed incorrect country ISO for Finland. #347

merged 3 commits into from
Aug 13, 2020

Conversation

unbugged
Copy link
Contributor

What kind of change does this PR introduce?

The incorrect ISO code fi-FL for Finland will be changed to the correct one of fi-FI.

What is the current behavior?

The ISO code is fi-FL.

What is the new behavior?

The ISO code will be fi-FI.

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

@vercel
Copy link

vercel bot commented Aug 11, 2020 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/arthurdenner/react-semantic-ui-datepickers/i9q75o2q1
✅ Preview: https://react-semantic-ui-datep-git-fork-unbugged-fix-incorrecti-8c0f4c.arthurdenner.vercel.app

@codecov
Copy link

codecov bot commented Aug 11, 2020 •
edited

Codecov Report

Merging #347 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #347   +/-   ##
========================================
  Coverage    87.78%   87.78%           
========================================
  Files           15       15           
  Lines          475      475           
  Branches        94       94           
========================================
  Hits           417      417           
  Misses          56       56           
  Partials         2        2
Impacted Files Coverage Δ
src/index.tsx 90.67% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63f8eb5...a7e0bd0. Read the comment docs.

@arthurdenner
Copy link
Owner

arthurdenner commented Aug 12, 2020 •
edited

@unbugged, thank you for fixing this. I don't really know why I broke it in another PR when fixed the Norwegian locale 🤔

Can you please rebase and solve the conflicts?

@arthurdenner arthurdenner changed the base branch from develop to master August 13, 2020 07:23
@arthurdenner arthurdenner changed the base branch from master to develop August 13, 2020 07:24
arthurdenner
arthurdenner approved these changes Aug 13, 2020
View reviewed changes
Copy link
Owner

@arthurdenner arthurdenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

@arthurdenner arthurdenner merged commit 27d2e04 into arthurdenner:develop Aug 13, 2020
@arthurdenner
Copy link
Owner

@all-contributors please add @unbugged for code and bug.

@allcontributors allcontributors bot mentioned this pull request Aug 13, 2020
Merged
@allcontributors
Copy link
Contributor

@arthurdenner

I've put up a pull request to add @unbugged! 🎉

@arthurdenner
Copy link
Owner

🎉 This PR is included in version 2.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arthurdenner arthurdenner arthurdenner approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@unbugged @arthurdenner