-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
staleIfError: true
should use the stale-if-error
directive if present
#506
Labels
bug
Something isn't working
good first issue
Good for newcomers
help wanted
Extra attention is needed
Comments
arthurfiorette
added
bug
Something isn't working
help wanted
Extra attention is needed
good first issue
Good for newcomers
labels
Feb 17, 2023
Anyone up to working on this? |
gmazoni
added a commit
to gmazoni/axios-cache-interceptor
that referenced
this issue
Feb 24, 2023
Merged
Working on |
Whoopsie, can you change the documentation where it was affected? axios-cache-interceptor/src/cache/cache.ts Line 167 in ee8b6b3
and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
good first issue
Good for newcomers
help wanted
Extra attention is needed
Describe the bug
When using
staleIfError: true
, its time is resolved as forever, but if the cache-control header included astale-if-error
directive, that time should be used instead.To Reproduce
Expected behavior
When
staleIfError
is true and the server returned thestale-if-error
directive, it should behave exactly the same asstaleIfError: <ms in the stale-if-error directive>
Additional context
v1.3.1
v1.0.1
The text was updated successfully, but these errors were encountered: