Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"swig_runtime_data" is not a valid constant name in Ruby #37

Closed
brixen opened this issue Feb 19, 2011 · 5 comments
Closed

"swig_runtime_data" is not a valid constant name in Ruby #37

brixen opened this issue Feb 19, 2011 · 5 comments

Comments

@brixen
Copy link

brixen commented Feb 19, 2011

In Ruby, constant names begin with an uppercase character.

https://github.com/fauna/memcached/blob/master/ext/rlibmemcached_wrap.c#L1737

@evan
Copy link
Collaborator

evan commented Feb 19, 2011

Does this cause any actual problem? Note that it's in the autogenerated SWIG code, so potentially an issue in SWIG.

@brixen
Copy link
Author

brixen commented Feb 19, 2011

Unfortunately, yes.

https://github.com/evanphx/rubinius/issues#issue/692

Evan (the other Evan :) pointed out this is SWIG. I looked at their sourceforge project and it's got 173 open bugs, so getting it fixed might not be easy.

I'm not sure what the best approach is. But this is really bad on SWIG's part.

@rocky
Copy link

rocky commented Feb 20, 2011

@evan
Copy link
Collaborator

evan commented Feb 22, 2011

Added a dumb fix to 1.0.7.

@rocky
Copy link

rocky commented Feb 22, 2011

Great! Will try to get those changes back into Swig.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants