Definition of 'Done'

[HiranChaudhuri]

When running gdexporter on one project, I get this output:

📓 No config file found!
⌛ Loading plugins...
⌛ Loading GDCore...
🕗 Getting latest release tag...
❌ The GDevelop version was not found, downloading it!
🕗 Starting download of GDevelop Runtime 'v5.0.120'...
🕗 Starting download of GDevelop Core...
✅ Done downloading libGD.js
✅ Done downloading libGD.wasm
✅ Done downloading GDevelop Runtime 'v5.0.120'
🕗 Extracting GDevelop Runtime 'v5.0.120'...
✅ Done extracting the GDevelop Runtime
🕗 Compiling Runtime...
✅ Runtime built in 827ms
✅ Successfully downloaded GDevelop version 'v5.0.120'
⌛ Loading project...
⌛ Plugins are preprocessing the project...
📦 Exporting for HTML5 (default)
copyFile(/project/images/strip_grass.png, /output/strip_grass.png) failed: Error: ENOENT: no such file or directory, stat '/project/images/strip_grass.png'
copyFile(/project/images/strip_water.png, /output/strip_water.png) failed: Error: ENOENT: no such file or directory, stat '/project/images/strip_water.png'
copyFile(/project/sounds/plane_explodes.wav, /output/plane_explodes.wav) failed: Error: ENOENT: no such file or directory, stat '/project/sounds/plane_explodes.wav'
⌛ Plugins are patching index.html...
⌛ Plugins are postprocessing the export...
✅ Done!

It looks to me as if there is a problem in my project. Indeed the files do not exist yet may be referenced in the game. This issue is project related and i need to fix it.

Puzzling though is the fact that gdexporter terminates with exit code 0, making this look like a success.
I suggest returning nonzero on any failure. Maybe a 1 for project related issues and 2 for more fatal issues.

[arthuro555]

This is not an error but a mere warning, in fact GDevelop will display the same messages in your console if you export it there and still tell you the export was successful without any additional messages in the UI. Those copy errors usually come from old unused resources that were not removed from the resources tab in GDevelop, you can do so by right clicking on any resources there and then selecting "remove unused resources" in the context menu.

I can add a flag to treat those as errors if you want, but I don't think they should be by default as they are just warnings?

[HiranChaudhuri]

I agree warnings should not terminate with nonzero unless someone activates a "--pedantic" options - which exists on GNU compilers and quite more programming languages. I see need for that both in the IDE as well on gdevelop - maybe something like that should be improved in the main product?

Another thing I can not easily agree on is that these messages are warnings only. I'm no pro in gdevelop, and the message contains the keyword "error". If it is a warning make it sound like a warning. But that again would be something to be fixed in the main project...

[arthuro555]

Well, it is technically a filesystem error as a file failed to copy, but GDevelop knows that this isn't an important file and that this filesystem error can be ignored, marking the build as successful. The messages are generated by the GDevelop core library that is merely downloaded and executed by gdexporter, I have no control over those.

[HiranChaudhuri]

I opened a feature request on the main project instead.