Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for subscripts #1

Closed
KennethNielsen opened this issue May 15, 2020 · 6 comments
Closed

Support for subscripts #1

KennethNielsen opened this issue May 15, 2020 · 6 comments
Assignees
@ArthurSonzogni
Labels
Accepted enhancement New feature or request

Comments

@KennethNielsen
Copy link

Hi This looks like a really cool project.

I'm wondering whether there is support for subscrips?
@ArthurSonzogni
Copy link
Owner

ArthurSonzogni commented May 15, 2020 •
edited

It looks like there isn't.
I will add it soon. Thanks for reporting this!

@KennethNielsen
Copy link
Author

No problem and thanks.

ArthurSonzogni added a commit that referenced this issue May 18, 2020
@ArthurSonzogni
Add support for subscript
4df472a 
Example:

Input:
┌───────────────────────────┐
│S_n = u_1 + u_2 + ... + u_n│
└───────────────────────────┘
Output:
┌───────────────────────┐
│S  = u  + u  + ... + u │
│ n    1    2          n│
└───────────────────────┘

This fixes issue:
#1
@ArthurSonzogni
Copy link
Owner

I should now be fixed. I will let you confirm this is working the way you intented.

@KennethNielsen
Copy link
Author

Hi @ArthurSonzogni thanks so much. There is one minor issue with, but I don't know if it is WontFix since it does make the layout considerations larger. For the usecase that I wanted to use it for, I would often be applying both a subscript and a superscript. But when I do, it seems to use the horizontal position of the ?-script I apply first, which makes it look a little odd.

Example if I want to add super script "i" and subscript Oxygen to an E. If I do E^i_Oxygen it produces:

 i      
E       
  Oxygen

and if I flip them the other way around, E_Oxygen^i, it does:

       i
E       
 Oxygen

where what I was hoping for is:

 i
E       
 Oxygen

@ArthurSonzogni ArthurSonzogni reopened this Jun 4, 2020
@ArthurSonzogni
Copy link
Owner

This sounds like a good thing to do!

@ArthurSonzogni ArthurSonzogni added Accepted enhancement New feature or request labels Jun 24, 2020
@ArthurSonzogni ArthurSonzogni self-assigned this Jun 24, 2020
@ArthurSonzogni
Copy link
Owner

Done! I finally added the optimization you suggested in:
#1 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArthurSonzogni ArthurSonzogni

Labels
Accepted enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KennethNielsen @ArthurSonzogni