Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequence: a way to make a visual difference between async and sync calls #68

Closed
bjornstromberg opened this issue Aug 6, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@bjornstromberg
Copy link

as i wrote in issue #63 a way to quickly see if a sequence call is async or sync would be a great enhancement.

as an example solid lines would be sync, and for example dashed lines would be async.

as things are now i use '(as)' in the line message to denote the async calls but it clutters the view for such a simple thing as a dashed line would solve.

its a great tool so far.

@ArthurSonzogni ArthurSonzogni self-assigned this Aug 8, 2023
@ArthurSonzogni ArthurSonzogni added the enhancement New feature or request label Aug 8, 2023
@ArthurSonzogni
Copy link
Owner

What about something like:

->  : arrow
--> : dashed arrow

I wonder how to represent them both, in both ascii-only and unicode versions.

@bjornstromberg
Copy link
Author

absolutely that would work in the 'input' format.

i would probably represent them the same way they are now,
just that the dashed ones, if required to be spaced apart to make it visible they are different.

another way, would be using color coding by specifying the requested color pair, with a default set like dark-grey / light-grey or anything that should work on most terminals (usually black background)

color coding will likely be a larger breaking change for a lot of components.

ArthurSonzogni added a commit that referenced this issue Aug 12, 2023
ArthurSonzogni added a commit that referenced this issue Aug 27, 2023
@ArthurSonzogni
Copy link
Owner

I think we can close this, thanks to #69

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants