Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hw08 reading for grading #10

Open
arthursunbao opened this issue Nov 22, 2017 · 2 comments
Open

hw08 reading for grading #10

arthursunbao opened this issue Nov 22, 2017 · 2 comments

Comments

@arthursunbao
Copy link
Owner

No description provided.

@suminwei2772
Copy link

Hi @arthursunbao !
Nice Shiny app! The new features listed in your README.md file were all properly implemented in your shiny app. I like how your can filter the output based on your own preferences of the product type and country. The table is interactive, and I did check that the files download properly as a .csv file.
The app was also set up using separate ui.R and server.R files. Code is clean and organized.
Though the data set was taken from what we had covered in class, I think it would've still been useful to include an explanation of the data you used in the app. Also, it would be good to include a progress report/problems encountered section to discuss some of the issues you came across and how you solved them!
But overall, good job!

@ksedivyhaley
Copy link
Collaborator

App uses ui.R and server.R file: Yes
Deployed online: Yes
Course repo includes README, code: Yes
Acknowledge datset source: No
New app or 3+ added features: Yes (4 features)
Reflection: No

Comments:

  • You should remove unnecessary files from your repo (eg app.R, the bclogo.jpg file that isn't in the www folder).
  • Solid implementation of chosen features, with one minor bug:
  • Text reads “Number of 1 results for you” when one result is returned. It would be nice to print “1 result.”

Your mark will be distributed later. If you would like more feedback, please feel free to message me on slack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants