Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement String#end_with? and String#start_with? in Rust #2186

Closed
lopopolo opened this issue Sep 21, 2022 · 0 comments · Fixed by #2220
Closed

Implement String#end_with? and String#start_with? in Rust #2186

lopopolo opened this issue Sep 21, 2022 · 0 comments · Fixed by #2220
Labels
A-performance Area: Performance improvements and optimizations. A-ruby-core Area: Ruby Core types. B-mruby Backend: Implementation of artichoke-core using mruby. C-enhancement Category: New feature or request.

Comments

@lopopolo
Copy link
Member

These two functions are written in Ruby. If moved to Rust, they can be implemented with fewer allocations.

It would also allow gating the Regexp paths behind a feature flag.

Be sure to remove the pure Ruby variants.
@lopopolo lopopolo added A-performance Area: Performance improvements and optimizations. A-ruby-core Area: Ruby Core types. B-mruby Backend: Implementation of artichoke-core using mruby. C-enhancement Category: New feature or request. labels Sep 21, 2022
@xulaus xulaus mentioned this issue Oct 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-performance Area: Performance improvements and optimizations. A-ruby-core Area: Ruby Core types. B-mruby Backend: Implementation of artichoke-core using mruby. C-enhancement Category: New feature or request.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Rust implementation of start_with? and end_with?
1 participant
@lopopolo