added interface for collector

[pxp928]

Signed-off-by: pxp928 parth.psu@gmail.com

Added interface for collector. Utilizing a configuration to specify the bucket address and such. Currently implementing the google cloud bucket interface.

[pxp928]

@lumjjb Ready for re-review.

[lumjjb]

let's add some here :)

[mihaimaruseac]

(looked at it thinking it was the PR we paired on today, got a few questions only)

[mihaimaruseac]

I'm thinking that we can do a modular registration approach like in

guac/pkg/ingestor/processor/process/process.go

Lines 26 to 39 in 3ef1b5a

	var (
	documentProcessors = map[processor.DocumentType]processor.DocumentProcessor{}
	)
	func init() {
	// Registerprocessor.DocumentProcessor()
	}
	func RegisterDocumentProcessor(p processor.DocumentProcessor, d processor.DocumentType) {
	if _, ok := documentProcessors[d]; ok {
	logrus.Warnf("the document processor is being overwritten: %s", d)
	}
	documentProcessors[d] = p
	}

here too. This way, when we add a new collector config, we only need to import the package that defines the global registry, let its init initialize whatever additional static fields are needed, call the Register... function and later at runtime select the corresponding collector from the map.

We can also go with this for now and refactor later, though it might be more work.

[pxp928]

Yes this was the piece I was asking about. Need to rethink the initializing piece. I will do it the other way as it makes more sense.

[mihaimaruseac]

This is like a sum type, right? That is, only one of these configs should be set at any given time during runtime?

[pxp928]

Closing PR for redesign.