Set the dispatch queue explicitly #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…It specifies a queue to dispatch the signal fire to the listener. Added unit tests.
| @@ -113,6 +113,14 @@ networkLoader.onProgress.listen(self) { (progress) in | |||
| }.queueAndDelayBy(1.0) | |||
| ``` | |||
|
|
|||
| A signal dispatches listener calls synchronously on the posting thread by default. To specify the thread explicitly, you should use the `dispatchOnQueue` method: | |||
There was a problem hiding this comment.
Probably worth mentioning that if you explicitly set a thread it will be called asynchronously.
|
Just a few small comments, looks good otherwise. Thanks for the contribution! |
|
Thanks. I updated the pull request accordingly. |
|
Travis failed on one of the asynchronous waits. Might make sense to increase the wait time to 0.2 seconds for example. |
…chQueue and testUsesCurrentQueueByDefault tests.
|
Increased the wait time to 0.2s for both tests. Unit tests shouldn't fail occasionally this time. |
|
Looks good. Thanks! |
artman
added a commit
that referenced
this pull request
Dec 7, 2015
Set the dispatch queue explicitly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A signal dispatches listener calls synchronously on the posting thread by default.
Added the
dispatchOnQueuemethod to specify the queue explicitly. Updated the readme file and implemented unit tests.