Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CocoaPods dependency issue #75

Closed
LinusU opened this issue Mar 11, 2019 · 10 comments
Closed

CocoaPods dependency issue #75

LinusU opened this issue Mar 11, 2019 · 10 comments

Comments

@LinusU
Copy link
Contributor

LinusU commented Mar 11, 2019

I'm still quite new to CocoaPods so I'm trying to figure out if it's me doing something wrong, but for some reason, CocoaPods doesn't think that Signals 6.0.0 support osx:

- ERROR | [OSX] unknown: Encountered an unknown error (The platform of the target `App` (macOS 10.13) is not compatible with `Signals (6.0.0)`, which does not support `osx`.) during validation.

But looking at your pod-spec I cannot find anything that could cause this 🤔

This is my pod-spec btw.

Pod::Spec.new do |s|
  s.name         = "Marionette"
  s.version      = %x(git describe --tags --abbrev=0).chomp
  s.summary      = "Swift library which provides a high-level API to control a WKWebView"
  s.description  = "Marionette is a Swift library which provides a high-level API to control a WKWebView. The goal is to have the API closely mirror that of Puppeteer."
  s.homepage     = "https://github.com/LinusU/Marionette"
  s.license      = "MIT"
  s.author       = { "Linus Unnebäck" => "linus@folkdatorn.se" }

  s.swift_version = "4.0"
  s.ios.deployment_target = "11.0"
  s.osx.deployment_target = "10.13"

  s.source       = { :git => "https://github.com/LinusU/Marionette.git", :tag => "#{s.version}" }
  s.source_files = "Sources"

  s.dependency "LinusU_JSBridge", "1.0.0-alpha.14"
  s.dependency "PromiseKit", "~> 6.0"
  s.dependency "Signals", "~> 6.0"
end

Maybe this should be reported to the CocoaPods repo? 🤔

@LinusU
Copy link
Contributor Author

LinusU commented Mar 11, 2019

I should mention that pod lib lint --platforms=ios works, it's just the osx platform that it has problems with. Will investigate more tomorrow and open upstream bug if I can't figure it out...

@LinusU
Copy link
Contributor Author

LinusU commented Mar 12, 2019

The problem is that osx is missing in platforms on 6.0.0, no idea why though 🤔

https://github.com/CocoaPods/Specs/blob/bab0d1ac6fe998de02d2998cdb04e3e55cfcbd0f/Specs/c/a/d/Signals/6.0.0/Signals.podspec.json#L15-L19

@LinusU
Copy link
Contributor Author

LinusU commented Mar 12, 2019

@artman would you mind bumping and publishing as 6.0.1, it seems like something went wrong with the uploading to CocoaPods, but they aren't accepting changes to existing serialized podspeces...

It would really help me out ☺️

@artman
Copy link
Owner

artman commented Mar 20, 2019

Hmm, I don't think bumping an re-publishing will help here, there must be something wrong with the podspec.

@LinusU
Copy link
Contributor Author

LinusU commented Mar 20, 2019

The podspec has worked for all earlier versions though, and haven't been changed 🤔

That led me to believe that there was just something that went wrong during publishing...

@stephanheilner
Copy link
Contributor

pod lib lint --verbose works without any problems with the latest and greatest.

 ** BUILD SUCCEEDED ** [1.767 sec]
    
   Testing with `xcodebuild`. 
 -> Signals (6.0.0)
    - NOTE  | xcodebuild:  note: Using new build system
    - NOTE  | xcodebuild:  note: Planning build
    - NOTE  | xcodebuild:  note: Constructing build description
    - NOTE  | xcodebuild:  warning: Skipping code signing because the target does not have an Info.plist file. (in target 'App')

It didn't work with CocoaPods 1.5.3, but now that the latest and greatest is 1.6.1, the lint works fine. You should be good to go now.

@artman
Copy link
Owner

artman commented Mar 20, 2019

Bumped 6.0.1 and released, but as I suspected, the Cocoapods repo still doesn't pick up on MacOS compatibility. I'm at a loss, any suggestions on fixing this?

@stephanheilner
Copy link
Contributor

I can take a look, I'm pretty familiar with CocoaPods. And I've got a few macOS projects I could test this with.

@stephanheilner
Copy link
Contributor

Adding support for OSX:

s.ios.deployment_target = '8.0'
  s.tvos.deployment_target = '9.0'
  s.watchos.deployment_target = '2.0'
  s.osx.deployment_target = '10.11'

The pod lib lint --verbose still works:

 ** BUILD SUCCEEDED ** [2.584 sec]
    
   Testing with `xcodebuild`. 
 -> Signals (6.0.1)
    - NOTE  | xcodebuild:  note: Using new build system
    - NOTE  | xcodebuild:  note: Planning build
    - NOTE  | xcodebuild:  note: Constructing build description
    - NOTE  | xcodebuild:  warning: Skipping code signing because the target does not have an Info.plist file. (in target 'App')

What problem are you seeing when you try?

@artman
Copy link
Owner

artman commented Apr 11, 2019

Fixed and published with 6.1.0. Thanks @stephanheilner!

@artman artman closed this as completed Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants