ResetFireCount method. Fix clearLastData documentation. #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resetting the fireCount was removed from clearLastData in e29f6ec. The inline documentation to reflect that has been updated. Resetting the fireCount is still useful.
zachstegall
referenced
this pull request
Apr 16, 2019
Improved comments. Don't reset the fireCount when clearing the lastDataFired. Remove unnecessary checks on fireCount.
|
HI @artman . Please take a look at this when you get the chance. |
|
Looks good, but Travis doesn't seem to find the iPhone 6 simulator anymore. I'll have to take a look unless you want to? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resetting the
fireCountwas removed fromclearLastDatain e29f6ec.The inline documentation to reflect that has been updated.
Resetting the
fireCountis still useful.