Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guitarsniffer is overly CPU intensive. #5

Open
MarcG2 opened this issue Aug 11, 2019 · 9 comments
Open

guitarsniffer is overly CPU intensive. #5

MarcG2 opened this issue Aug 11, 2019 · 9 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request question Further information is requested

Comments

@MarcG2
Copy link

MarcG2 commented Aug 11, 2019

When I have guitar sniffer running in the background, it completely maxes out one of my CPU cores and ends up using about 20% of my i7-8750H. Is there a reason the program needs to run unrestrained?

@Osin
Copy link

Osin commented Aug 12, 2019

Hello,
Same for me, 50% cpu average on laptop. So I can't play because it slow game to 20fps average.
I assume that 4 cpu cores is enough.

I hope to see quicky a fix.
Thanks for all

@artman41
Copy link
Owner

artman41 commented Sep 6, 2019

Hi guys,

I believe the issue is that I'm polling the device too many times for your CPUs.

My CPU is a Ryzen 7 1700 so I only see minor CPU usage on my end - likely because it's so much more powerful.

@MarcG2, @Osin, and anyone else that has this issue, could you please follow the below steps to get your DxDiag.txt and attach it to your comment?

Hopefully, if I can limit my CPU to have the same performance as yours, I can try and improve performance.

Getting DxDiag.txt

  1. WIN+R
    image

  2. Type dxdiag & Click OK
    image

  3. Click Save All Information
    image

  4. Save it in a place you know
    image

  5. Navigate to that directory
    image

  6. Drag it on to your comment
    DxDiag.txt

@artman41 artman41 self-assigned this Sep 6, 2019
@artman41 artman41 added bug Something isn't working enhancement New feature or request question Further information is requested labels Sep 6, 2019
@MarcG2
Copy link
Author

MarcG2 commented Sep 7, 2019

Here is my system info. What is the utility set to poll at currently? It seems like it's set poll as fast as possible.

DxDiag.txt

@artman41
Copy link
Owner

artman41 commented Sep 7, 2019

@MarcG2 so the offending function is this one, the issue is that I have no delay currently between reads, so it'll just keep reading as fast as possible until the sniffer is told to stop.

Personally I didn't see any huge performance hits from this, but it's quite obvious it must be terrible performance wise if you're seeing massive issues with it.

I'll try and add some delays in when I get some time; hopefully, by emulating your environment, it'll make it easier to spot the issues 👍

@Dunkalunk
Copy link

@artman41 I have Intel CPU's in my laptop and desktop I can test with. I noticed it was reading a high percentage, but I was never unable to play the game. But I can definitely help you look into it

@MarcG2
Copy link
Author

MarcG2 commented Jul 28, 2022

Was this issue ever addressed? It looks like the dev hasn't this updated this project since I first posted this.

Edit: Never mind. It looks like this version is now the recommended utility for RB4 controllers.
https://github.com/TheNathannator/RB4InstrumentMapper/releases

@Dunkalunk
Copy link

@MarcG2 that is perfect because artman has been MIA on this, and I never found more time to look into more and update it further. I also haven't found my wireless adapter since I moved to a new house, so I haven't even been able to test anything lately!

@MarcG2
Copy link
Author

MarcG2 commented Jul 30, 2022

@MarcG2 that is perfect because artman has been MIA on this, and I never found more time to look into more and update it further. I also haven't found my wireless adapter since I moved to a new house, so I haven't even been able to test anything lately!

I was trying out the other utility and it the controller seemed much less responsive than it should be. I'm not sure why, I'll need to test it more. If you get the chance to try it out, let me know

@Dunkalunk
Copy link

@MarcG2 sorry this is months later, just going through some old issues to get things updated. I got the latest version of that other tool installed and had no issues with guitar! Haven't tested with drums yet. I'm now recommending that tool be used since it's recommended by the Clone Hero team and is currently receiving updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants