Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchListsClassLoader usage #97

Closed
peteihis opened this issue Dec 25, 2018 · 4 comments
Closed

SearchListsClassLoader usage #97

peteihis opened this issue Dec 25, 2018 · 4 comments

Comments

@peteihis
Copy link
Contributor

At startup System.out gets lines like:

klo 13.09.46 [main] in SearchlistClassLoader.findResource() (SearchlistClassLoader.java:442)
   findResource: looking in artofillusion.util.SearchlistClassLoader@6986852 for artofillusion/PluginRegistry.groovy

.....

klo 13.09.46 [main] in SearchlistClassLoader.findResource() (SearchlistClassLoader.java:442)
   findResource: looking in artofillusion.util.SearchlistClassLoader@3d121db3 for Script1$1Customizer.groovy

Lines 58 to 371in that case.

I'm not sure what is supposed to happen there, but it seems, that SriptRunner is looking for a set of groovy files in the code structure, that obviously aren't there. On top of that it is set to report the "looking for" but not if the file was found or not.

This is probably a minor issue from the user's point of view, but it doesn't seem right either. Can the line 442 in SearchlistClassLoader at least be commented out?

@peteihis
Copy link
Contributor Author

peteihis commented Jan 7, 2019

This did no occur with the latest HEAD. I wonder is the behavior is related to a plugin? The line 442 is still here.

@Sailsman63
Copy link
Member

This is just SearchListClassLoader being talkative. It tends to log all of it's thoughts out loud as it searches for various class resources. The order in which it searches depends on exact details of your installation, and what plugins are installed, etc.

Don't worry about it looking in what humans would consider "nonsensical" locations. It literally looks through all plugin locations that it has not yet searched until it finds what it needs.

@peteihis
Copy link
Contributor Author

I was not worried about it looking into everywhere but I find it rather annoying that it chooses to report all the places it' is looking at. That looks more like development like debugging to me. I'd suggest to comment out that one line and have it just to report if a particular bit was found or not.

@Sailsman63
Copy link
Member

The problem is that there are several lines like that in there. We need to decide how we want to handle logging, rather than just commenting out code. (There is a separate issue for that - I've got other priorities at the moment though.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants