Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forceLanguageLocalization doesn't change the language. #67

Closed
nmizoguchi opened this issue Jun 2, 2016 · 6 comments
Closed

forceLanguageLocalization doesn't change the language. #67

nmizoguchi opened this issue Jun 2, 2016 · 6 comments

Comments

@nmizoguchi
Copy link

The alert shows english text even after setting to other SirenLanguageType (I'm using PortugueseBrazil).
@ArtSabintsev
Copy link
Owner

I'll look into it.

@ArtSabintsev
Copy link
Owner

Confirmed that this is a problem. I'm working on writing some tests to pinpoint if other languages are affected as well.

Thanks for bringing it to my attention.

@ArtSabintsev ArtSabintsev mentioned this issue Jun 8, 2016
Merged
@ArtSabintsev
Copy link
Owner

I'll tackle this issue once I've finished writing the tests in #68.

@nmizoguchi
Copy link
Author

I'm the one who should be thanking you for saving me a lot of time! :) I'm Glad I could help in some way.

@ArtSabintsev
Copy link
Owner

I fixed the issue in here: ba1fa10

It's currently in the Tests PR I'm working on. Will pull it in later today.

Arthur

@ArtSabintsev
Copy link
Owner

Closing this issue, as I've fixed the problem in #68, which will be merged soon.

@yemartin yemartin mentioned this issue Jun 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ArtSabintsev @nmizoguchi