Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Current Lot link should not scroll with lots #1538

Closed
ashfurrow opened this issue May 24, 2016 · 5 comments
Closed

Current Lot link should not scroll with lots #1538

ashfurrow opened this issue May 24, 2016 · 5 comments
Labels
Auctions
Milestone
Auction Sprint: S...

Comments

@ashfurrow
Copy link
Contributor

It should stay fixed like the auction progress bar and not be duplicated across lots. Reported on Hockey.
@ashfurrow
Copy link
Contributor Author

Shouldn't be too difficult, but it is a change to our layout. I'll roll this into #1506.

@katarinabatina are there details available for how this is shown/hidden when the user navigates between lots by swiping on iPhone?

@katarinabatina
Copy link

The live lot link should animate from the bottom up when navigating to a lot that is not the live lot, and animate down and away when the user navigates back to the live lot.

@ashfurrow
Copy link
Contributor Author

Talked with Katarina, we need to present the sale info VC in a modal, not a push.

@ashfurrow ashfurrow mentioned this issue May 26, 2016
Merged
@katarinabatina
Copy link

@ashfurrow from today in sprint kickoff

@ashfurrow
Copy link
Contributor Author

Issue moved to artsy/auctions #191 via ZenHub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Auctions
Projects
None yet
Milestone
Auction Sprint: Sep 26 - Oct 7
Development

No branches or pull requests
3 participants
@ashfurrow @devangt @katarinabatina