Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove algolia-backed components #9003

Merged
merged 9 commits into from
Jul 17, 2023

Conversation

dblandin
Copy link
Member

@dblandin dblandin commented Jul 17, 2023

This PR resolves ONYX-18

Description

Removes Algolia-backed components and any Elastic/Algolia feature flagging in favor of components/queries that are fully backed by Metaphysics.

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Dev changes

  • remove Algolia-backed components and any Elastic/Algolia feature flagging in favor of components/queries that are fully backed by Metaphysics.

Need help with something? Have a look at our docs, or get in touch with us.

@dblandin dblandin self-assigned this Jul 17, 2023
@dblandin
Copy link
Member Author

fyi — this likely supersedes the work started in this branch.

gkartalis
gkartalis previously approved these changes Jul 17, 2023
Copy link
Member

@gkartalis gkartalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! One thing only:

  • Noticed that the Gemfile.lock still has algoliasearch as a dep 🤔 how do we get rid of that? 😅

I guess if we run bundle update it will also update a bunch of unrelated things, is there a ruby way of refreshing it to remove only algoliasearch?

@dblandin
Copy link
Member Author

Noticed that the Gemfile.lock still has algoliasearch as a dep 🤔 how do we get rid of that? 😅

Nice catch and I noticed that too but it looks like it's a dependency of cocoapods-core so might not be able to drop it at this time.

Copy link
Member

@gkartalis gkartalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dblandin actually there is another thing that we need to remove, there is this dep called search-insights that we introduced for tracking algolia related stuff that we no longer need along with the useSearchInsights hook

@dblandin
Copy link
Member Author

@gkartalis Good catch! Removed in 7f2aeeb 👍🏼

Copy link
Member

@anandaroop anandaroop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🧹 thanks for picking this up!

@dblandin dblandin merged commit 5be3c96 into main Jul 17, 2023
8 checks passed
@dblandin dblandin deleted the dblandin/remove-algolia-components branch July 17, 2023 14:12
@MounirDhahri MounirDhahri mentioned this pull request Apr 29, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants