-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove algolia-backed components #9003
Conversation
fyi — this likely supersedes the work started in this branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! One thing only:
- Noticed that the Gemfile.lock still has
algoliasearch
as a dep 🤔 how do we get rid of that? 😅
I guess if we run bundle update
it will also update a bunch of unrelated things, is there a ruby way of refreshing it to remove only algoliasearch
?
Nice catch and I noticed that too but it looks like it's a dependency of cocoapods-core so might not be able to drop it at this time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gkartalis Good catch! Removed in 7f2aeeb 👍🏼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 🧹 thanks for picking this up!
This PR resolves ONYX-18
Description
Removes Algolia-backed components and any Elastic/Algolia feature flagging in favor of components/queries that are fully backed by Metaphysics.
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.