Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow a longer timeout for pod to enter running state #331

Open
artsyjian opened this issue Feb 2, 2023 · 0 comments
Open

allow a longer timeout for pod to enter running state #331

artsyjian opened this issue Feb 2, 2023 · 0 comments
Labels
low low importance

Comments

@artsyjian
Copy link
Contributor

kubectl run has a --pod-running-timeout flag which controls how long kubectl waits for the pod to enter running state. The default is 1 minute which is not always realistic since sometimes it can take longer than that, for example, if the Docker image is very large, or Kubernetes cluster scale-up is required, etc.

Here's what happens when the timeout is reached, using a 1 second timeout as an example:

$ kubectl run -it --pod-running-timeout=1s --image=busybox --rm test sh
pod "test" deleted
error: timed out waiting for the condition

$ kubectl version
Client Version: version.Info{Major:"1", Minor:"19", GitVersion:"v1.19.16", GitCommit:"e37e4ab4cc8dcda84f1344dda47a97bb1927d074", GitTreeState:"clean", BuildDate:"2021-10-27T16:25:59Z", GoVersion:"go1.15.15", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"19", GitVersion:"v1.19.16", GitCommit:"e37e4ab4cc8dcda84f1344dda47a97bb1927d074", GitTreeState:"clean", BuildDate:"2021-10-27T16:20:18Z", GoVersion:"go1.15.15", Compiler:"gc", Platform:"linux/amd64"}

This issue requests that the flag be configurable through hokusai staging/production run ... commands. Currently it is not configurable.

$ hokusai staging run --help
Usage: hokusai staging run [OPTIONS] COMMAND

  Launch a new container and run a command

Options:
  --tty              Attach the terminal
  --tag TEXT         The image tag to run (defaults to "staging")
  --env TEXT         Environment variables in the form of "KEY=VALUE"
  --constraint TEXT  Constrain command to run on nodes matching labels in the form of "key=value"
  -v, --verbose      Verbose output
  -h, --help         Show this message and exit.

And the call to kubectl leaves the flag at default.

@artsyjian artsyjian added the high high importance label Feb 2, 2023
@artsyjian artsyjian added low low importance and removed high high importance labels Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low low importance
Projects
None yet
Development

No branches or pull requests

1 participant